feat(protocol): introduce ForkManager to improve protocol fork management #18508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The storage layout of ForkManager is compatible with the layout of TaikoL1. 
|
feat(protocol): introduce ForkManager to improve protocol fork management
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
YoGhurt111
reviewed
Nov 25, 2024
adaki2004
reviewed
Nov 25, 2024
adaki2004
reviewed
Nov 25, 2024
adaki2004
approved these changes
Dec 6, 2024
davidtaikocha
approved these changes
Dec 16, 2024
davidtaikocha
approved these changes
Dec 16, 2024
YoGhurt111
approved these changes
Dec 16, 2024
YoGhurt111
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the TaikoL1 protocol required each fork's codebase to contain implementations for both the current fork and the next fork within the same contract. This created unnecessary code complexity and tight coupling between fork versions.
With the new ForkManager, we can:
This change improves code maintainability and makes the fork upgrade process more modular.
BTW, I'm aware of Diamond proxy design but I'm in favor of this ForkManager implementation for its simplicity.